update export.md: clarify how extensions are exported #13327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```scala
object Members {
given x: Int = 4
given y: Comparable[String] with {override def compareTo(o: String): Int = ???}
extension (s: String) {
def ext1: String = ???
def ext2(p: Int) = ???
}
}
object Usage {
export Members.*
}
```
produces
```scala
scalac: package <empty> {
final lazy module val Members: Members = new Members()
final module class Members() extends Object() { this: Members.type =>
final lazy given val x: Int = 4
final lazy module given val y: Members.y = new Members.y()
final module class y() extends Object(), Comparable[String] {
this: Members.y.type =>
override def compareTo(o: String): Int = ???
}
extension (s: String) def ext1: String = ???
extension (s: String) def ext2(p: Int): Nothing = ???
}
final lazy module val Usage: Usage = new Usage()
final module class Usage() extends Object() { this: Usage.type =>
export Members.*
extension (s: String) final def ext1: String = Members.ext1(s)
extension (s: String) final def ext2(p: Int): Nothing = Members.ext2(s)(p)
}
}
```
|
@unkarjedy we actually shouldnt be updating the docs at this repo anymore, please can you replicate the same changes for this PR and #13339 at https://github.com/scala/docs.scala-lang |
|
OK But to avoid duplication and confusion in the future I think "Edit on Github" link should be removed from all the old pages |
|
BTW, I understand that it's subjective, but https://dotty.epfl.ch/docs/ design looks prettier and more modern |
unkarjedy
added a commit
to unkarjedy/docs.scala-lang
that referenced
this pull request
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs mention how types, terms, and givens are exported, but mention nothing about extensions.
produces