Use inline val for inlined final vals
#13989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
inline val for inlined final valsinline val for inlined final vals
These `val`s are already inlined and do not generate a field, but they still generate a getter that is never used. My marking these as `inline` we can remove the getter and save a few bytes at runtime. By making these fields `inline` we can also check that the RHS constant folds to a value at compile time.
nicolasstucki
force-pushed
the
use-inline-val-in-compiler
branch
from
9874d9a to
eba5290
Compare
smarter
requested changes
Nov 22, 2021
|
Those are only in the compiler. Not in the library. |
|
test performance please |
|
Test performance please |
|
@anatoliykmetyuk the benchmarking machine is not responding. |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/13989/ to see the changes. Benchmarks is based on merging with master (ca483f8) |
smarter
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
vals are already inlined and do not generate a field, but theystill generate a getter that is never used. My marking these as
inlinewe can remove the getter and save a few bytes at runtime.
By making these fields
inlinewe can also check that the RHS constantfolds to a value at compile time.