Skip to content

WIP: Enable explicit nulls in community build #14074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

olhotak
Copy link
Contributor

@olhotak olhotak commented Dec 8, 2021

Enables -Yexplicit-nulls for those community build projects that work with it.

Depends on #13975.

Currently applies only to sbt projects, not mill projects, because I don't know how to set scalacOptions from outside the project's own build file for mill.

The following 10 projects work with just -Yexplicit-nulls:

  • shapeless
  • discipline
  • disciplineSpecs2
  • simulacrumScalafixAnnotations
  • scissEqual
  • scissFingerTree
  • scissModel
  • scissNumbers
  • scissSpan
  • akka

34 projects work with -Yexplicit-nulls and -language:unsafeNulls.

The following projects don't compile even with -language:unsafeNull:

  • scalacheck
  • scalatest
  • scalatestplusScalacheck
  • scalatestplusJunit
  • scalatestplusTestNG
  • scalaXml
  • scalaPB
  • stdLib213
  • effpi
  • sconfig
  • scalaz
  • catsEffect3
  • onnxScala
  • libretto
  • jacksonModuleScala

A summary of the errors in some of the above projects is in this file:
dotty-cb-exp-null.txt

Co-authored-by: Sebastian Wilzbach <[email protected]>
@ckipp01
Copy link
Member

ckipp01 commented May 10, 2023

I'm going to go ahead and close to inactivity. @olhotak if this is still something you want to work on, feel free to comment back, rebase, and re-open!

@ckipp01 ckipp01 closed this May 10, 2023
@WojciechMazur WojciechMazur deleted the enable-explicit-nulls branch December 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants