-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Scala 2.13.8 (was 2.13.6) #14258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.13.8 (was 2.13.6) #14258
Conversation
Is the test failure something I should just add a checkfile update for? |
No, the output is wrong:
instead of underscore
Vulpix not running in But it's great that the message uses |
Is this conceivably related to the Scala 2 version bump? |
As Wallace Shawn famously says in the movie, "Inconceivable!" |
No, it wasn't caused by this Scala version bump, because it's already broken by bumping to 2.13.7! |
Eerily, 2.13.7 includes "Fix 2.13.7 regression affecting wildcards and F-bounded types" and happens to break "F-bounds of type parameters may not be type lambdas/Type argument C does not have the same kind as its bound [_]" on the other compiler. This is why the compilers share the least amount of code possible. |
It's due to the wildcard in the sig, but I didn't decide if the change is as intended. I saw the discussion with Lukas, which I'll revisit. I guess Scala 3 will also emit funny-looking temp names in messages? so who cares, just update the check file. |
link? in the meantime, I've updated the checkfile. |
After poking around where I don't yet understand, I guessed scala/scala#9806 or scala/scala#9815 changed the signature (of IterableOps?) seen by Scala 3 so it gets |
RefChecks can't change the signature though - it's just checks. Maybe scala/bug#12488 but that applies only to existential types and this is a higher-kinded type right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to also keep the stdlib213 submodule up-to-date.
ah, good call, that didn't occur to me. I've added it to the Scala 2 release steps: scala/scala-dev@1602898 and I've opened #14322 fyi @lrytz |
Is this being considered for 3.1.x, or will it wait for 3.2? |
This PR is part of 3.1.2-RC1 (you can see the first tag a PR was part of at the top of the page on github). |
duh, sorry. I also should have thought to check this:
|
Not sure what the policy is — is this eligible for 3.1.1, or does it wait for 3.2?
Also not sure if 2.13.7 was skipped for a reason, or just nobody thought of it. Regardless, I've added opening a PR such as this one to the Scala 2 release steps, for next time.