Tighten unary op syntax and untupling language#14372
Merged
Merged
Conversation
anatoliykmetyuk
suggested changes
Jan 28, 2022
Contributor
Author
|
It's not obvious to me that the reason I can't define is that I wouldn't be able to write prefix op syntax. What if I had no intention of using prefix op syntax? Perhaps my purpose was to sabotage prefix syntax for subclasses. This is probably the only case where syntax restricts a regular language feature. For example, I can write extensions for |
Contributor
Author
|
I used github's "commit suggestion" feature for the first time, but I see that it triggers tests. |
b9462ca to
6e84331
Compare
Contributor
Author
|
Rebased for conflicts, but accidentally lost review tweaks added via suggested edits. Re-added tweaks per review. |
anatoliykmetyuk
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9241
Disallow unary ops with parens.
Follow up untupling spec where it is not pattern-matching like
.tupled. It simply takes the params it knows to take.