Adapt function arguments to n-ary prototype#14651
Merged
Merged
Conversation
If a function argument is a synthetic term of the form x$1 => x$1 match case (a_1, ..., a_n) => e and the expected type is an n-ary function type, rewrite the argument to (a_1, ..., a_n) => e Fixes scala#14626. The example in scala#14626 now compiles without an implicit tupling conversion. Such a conversion was inserted before in 2.13, 3.0 and 3.1.
griggt
reviewed
Mar 10, 2022
Contributor
There was a problem hiding this comment.
This is very appealing, however is the following change in semantics expected?
@main def Test =
val xs = for {
(a, b) <- List("a", "b", "c").lazyZip(List(1, 2, 3))
} yield { println(s"computing $a + $b"); a + b }
println("and the result is:")
println(xs.toList)$ scalac lazyzip.scala && scala Test
and the result is:
computing a + 1
computing b + 2
computing c + 3
List(a1, b2, c3)
$ scalac -source:future lazyzip.scala && scala Test
computing a + 1
computing b + 2
computing c + 3
and the result is:
List(a1, b2, c3)
I suppose this could be considered an implementation detail, and anyone unwittingly relying on the current behavior should have written
- (a, b) <- List("a", "b", "c").lazyZip(List(1, 2, 3))
+ (a, b) <- List("a", "b", "c").lazyZip(List(1, 2, 3)).view
Contributor
Author
|
I think the expectation always was that the program is equivalent to @main def Test =
val xs = List("a", "b", "c").lazyZip(List(1, 2, 3)).map { (a, b) =>
println(s"computing $a + $b"); a + b
}
println("and the result is:")
println(xs.toList)So the old behavior would count as a bug, IMO. |
This was referenced Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a function argument is a synthetic term of the form
x$1 => x$1 match case (a_1, ..., a_n) => e
and the expected type is an n-ary function type, rewrite the argument to
(a_1, ..., a_n) => e
Fixes #14626.
The example in #14626 now compiles without an implicit tupling conversion.
Such a conversion was inserted before in 2.13, 3.0 and 3.1.