Skip to content

Implement new main annotation #14841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Apr 4, 2022

Followup to #14558 adding the missing new main annotation form #13727.

This is a finished version of the new main annotation design of #13727. This is not necessarily intended to be the final version. We want to add it as experimental to allow users to try it out and promote further design discussions in #14977.

@nicolasstucki nicolasstucki self-assigned this Apr 4, 2022
@nicolasstucki nicolasstucki force-pushed the implement-new-main branch 3 times, most recently from d50e119 to c0475d9 Compare April 6, 2022 10:05
@nicolasstucki nicolasstucki force-pushed the implement-new-main branch 2 times, most recently from 29e6a78 to fe7c3e1 Compare April 14, 2022 15:56
@nicolasstucki nicolasstucki force-pushed the implement-new-main branch 8 times, most recently from 13f25fa to 8311fc8 Compare April 22, 2022 08:46
@nicolasstucki nicolasstucki marked this pull request as ready for review April 25, 2022 09:47
@anatoliykmetyuk
Copy link
Contributor

Hmm, so this annotation does exactly what @main does with the purpose to test out the new implementation and possibly replace @main in the future? I believe having two annotations doing the same thing will generate confusion. We should instead replace @main with this annotaiton right away and fix any regressions as they are reported IMO.

@julienrf
Copy link
Contributor

julienrf commented May 5, 2022

IMHO, the problem is not the risk of introducing regression, but the risk of introducing new features that will have to be maintained.

I think adding new features to the current @main annotation should be motivated by explaining why and how the current behavior is problematic.

@bishabosha
Copy link
Member

bishabosha commented May 5, 2022

We should instead replace @main with this annotaiton right away and fix any regressions as they are reported IMO.

this would mean making @main experimental because it would extend the experimental MainAnnotation

@nicolasstucki
Copy link
Contributor Author

rebased

nicolasstucki and others added 2 commits May 24, 2022 10:51
@nicolasstucki nicolasstucki enabled auto-merge June 1, 2022 18:39
@nicolasstucki nicolasstucki merged commit 707f9cb into scala:main Jun 1, 2022
@nicolasstucki nicolasstucki deleted the implement-new-main branch June 1, 2022 19:55
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants