Standardize -rewrite advertisements and suppress them in REPL
#14955
Conversation
|
@griggt Nice refactoring ( |
|
ping for review |
griggt
force-pushed
the
standardize-rewrite-ads
branch
from
4696622 to
62b2138
Compare
| report.warning( | ||
| ex"""pattern's type ${pat.tpe} $problem the right hand side expression's type $reportedPt | ||
| | | ||
| |If the narrowing is intentional, this can be communicated by $fix.${err.rewriteNotice}""", | ||
| |If the narrowing is intentional, this can be communicated by $fix.$rewriteMsg""", |
There was a problem hiding this comment.
Sorry my comment will be out of scope, but as a feature request, I wonder if there is a syntax to make string construction more intuitive or easier to read. Just thinking out loud, what if the rewrite message were given so that it needn't be stuck at the end by hand.
tests/neg/rewrite-messages.check
Outdated
| 7 | 2 foo 4 // error | ||
| | ^^^ | ||
| | Alphanumeric method foo is not declared `infix`; it should not be used as infix operator. | ||
| | Instead, use method syntax .foo(...) or rewrite as `foo`. |
There was a problem hiding this comment.
Im really not sure what "or rewrite as foo" is supposed to mean in this context, the original message was not clear either, but it seems that the "latter" that is rewritten automatically should be to method syntax, rather than "rewrite as foo".
Edit: ok I just realised that it meant "surround foo by backticks" - maybe this can be more explicit, because I interpreted it as "do nothing" - does not help that the other backticks in this error message just mean "code literal"
There was a problem hiding this comment.
I agree that backticks are the hardest problem in modern computer science. The reason we don't hear this opinion expressed on the forums is that it is inexpressible because it requires backticks to say it.
There was a problem hiding this comment.
I can see where that may be confusing. I pushed a change to try to improve the situation.
griggt
force-pushed
the
standardize-rewrite-ads
branch
from
62b2138 to
7b6b957
Compare
| i"""Alphanumeric $kind $name is not declared `infix`; it should not be used as infix operator. | ||
| |The operation can be rewritten automatically to `$name` under -deprecation -rewrite. | ||
| |Or rewrite to ${alternative(name)} manually.""", | ||
| i"""Alphanumeric $kind $name is not declared ${hl("infix")}; it should not be used as infix operator. |
There was a problem hiding this comment.
Unfortunately the syntax highlighting on infix has no effect, presumably because it is a soft keyword.
There was a problem hiding this comment.
could add some more utilities like:
def hlAsKeyword(str: String)(using Context): String =
if (str.isEmpty || ctx.settings.color.value == "never") str
else s"${SyntaxHighlighting.KeywordColor}$str${SyntaxHighlighting.NoColor}"
griggt
force-pushed
the
standardize-rewrite-ads
branch
from
7b6b957 to
97a20c7
Compare
griggt
force-pushed
the
standardize-rewrite-ads
branch
from
97a20c7 to
b4043e3
Compare
Extracted from #14294