Improve diagnostic for refutable extractors in pattern bindings #14988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
Apr 21, 2022
griggt
force-pushed
the
refutable-extractor-diagnostics
branch
from
6e62644 to
cb0457a
Compare
som-snytt
reviewed
May 9, 2022
som-snytt
reviewed
May 9, 2022
| else "will result in a filtering for expression (using `withFilter`)" | ||
| val usage = reason match | ||
| case NonConforming => "the narrowing" | ||
| case RefutableExtractor => "this usage" |
There was a problem hiding this comment.
Suddenly, I want to write two novels about the sinister underworld, one called "The Narrowing" and the other called "This Usage".
Avoids nonsensical messages such as: pattern's type Int is more specialized than the right hand side expression's type Int when the underlying cause is that the extractor is refutable.
griggt
force-pushed
the
refutable-extractor-diagnostics
branch
from
cb0457a to
3ddbf8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids nonsensical messages such as:
when the underlying cause is that the extractor is refutable.
Extracted from #14294