Fix implicit conversion type resolve in completions #15061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14687
The issue above is a result of previous implementation behind implicit conversion completions.
Previously we only checked possible conversions and collected all accessible members from that type.
It was impossible to infer types of type parameters in that solution.
I'm not sure if that's the best way to solve this but right now implicit conversion works similar to extension methods in completions. We try applying conversion to qualifier and then collect accessible members from type after conversion which type parameters are applied.
This will stay as draft until #15047 is merged as it changes completion style and conflicts will arise.