Skip to content

add comments for length and content().length in SourceFile #15121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

add comments for length and content().length in SourceFile #15121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/src/dotty/tools/dotc/util/SourceFile.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ class SourceFile(val file: AbstractFile, computeContent: => Array[Char]) extends

private var myContent: Array[Char] | Null = null

/** The contents of the original source file. Note that this can be empty, for example when
* the source is read from Tasty. */
def content(): Array[Char] = {
if (myContent == null) myContent = computeContent
myContent
Expand Down Expand Up @@ -92,6 +94,9 @@ class SourceFile(val file: AbstractFile, computeContent: => Array[Char]) extends

def apply(idx: Int): Char = content().apply(idx)

/** length of the original source file
* Note that when the source is from Tasty, content() could be empty even though length > 0.
* Use content().length to determine the length of content(). */
def length: Int =
if lineIndicesCache ne null then lineIndicesCache.last
else content().length
Expand Down