Skip to content

Hide fewer-braces page. #15336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

julienrf
Copy link
Contributor

See b1a6867.

@julienrf julienrf requested a review from pikinier20 May 31, 2022 08:17
@pikinier20
Copy link
Contributor

It only hides the page on reference documentation but the PR is targeted to main, so this change won't affect neither the dotty.epfl.ch nor docs.scala-lang.com until release

@odersky
Copy link
Contributor

odersky commented May 31, 2022

How do we hide a page that's no longer relevant?

@pikinier20
Copy link
Contributor

It's just matter of the sidebar.yml in which the change is introduced. This one is dedicated for reference documentation. Applying this change to docs/sidebar.yml will hide the page

@julienrf
Copy link
Contributor Author

It only hides the page on reference documentation but the PR is targeted to main, so this change won't affect neither the dotty.epfl.ch nor docs.scala-lang.com until release

Yes, the PR targets main because it reflects the current state (not yet released) of the compiler. I chose to hide the page from the sidebar to not break possible links from the outside.

@odersky
Copy link
Contributor

odersky commented May 31, 2022

Yes, the PR targets main because it reflects the current state (not yet released) of the compiler. I chose to hide the page from the sidebar to not break possible links from the outside.

Makes sense.

@pikinier20
Copy link
Contributor

It only hides the page on reference documentation but the PR is targeted to main, so this change won't affect neither the dotty.epfl.ch nor docs.scala-lang.com until release

Yes, the PR targets main because it reflects the current state (not yet released) of the compiler. I chose to hide the page from the sidebar to not break possible links from the outside.

But shouldn't we hide the page on both sidebars?

@julienrf
Copy link
Contributor Author

julienrf commented Jun 1, 2022

But shouldn't we hide the page on both sidebars?

I’d like to ask Martin about this change then, since that would impact dotty.epfl.ch. On my side, I’m fine with removing the page from dotty.epfl.ch because I think this website is more like a “live” documentation of the nightly state of the compiler.

@odersky
Copy link
Contributor

odersky commented Jun 1, 2022

The page can be hidden from both sidebars.

@julienrf
Copy link
Contributor Author

julienrf commented Jun 1, 2022

OK, I pushed another commit to align both websites. They now both render the page, but hide them from the sidebar.

@julienrf julienrf merged commit 42b5941 into scala:main Jun 2, 2022
@julienrf julienrf deleted the update-stable-sidebar branch June 2, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants