Fix computation of class nesting level in inliner #15671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jul 13, 2022
| @@ -270,12 +270,15 @@ class Inliner(val call: tpd.Tree)(using Context): | |||
| assert(argss.isEmpty) | |||
| true | |||
|
|
|||
| /** The number of enclosing classes of this class, plus one */ | |||
| private def nestingLevel(cls: Symbol) = cls.ownersIterator.count(_.isClass) | |||
There was a problem hiding this comment.
maybe call it outerLevel to avoid confusion with ctx.nestingLevel used in level-checking?
There was a problem hiding this comment.
I renamed it to classNestingLevel.
dwijnand
approved these changes
Jul 13, 2022
Kordyjan
added
the
backport:accepted
Kordyjan
added
backport:done
Kordyjan
added a commit
that referenced
this pull request
Jul 27, 2022
Backport #15671: Fix computation of class nesting level in inliner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15666