Tweak Http4s in the CB #15773
Merged
Tweak Http4s in the CB #15773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Jul 28, 2022
| lazy val catsEffect3 = SbtCommunityProject( | ||
| project = "cats-effect-3", | ||
| sbtTestCommand = "ciJVM", | ||
| sbtTestCommand = "ciJVM; ciJS", |
Contributor
Author
There was a problem hiding this comment.
To help prevent JS-specific regressions e.g. #15494.
Contributor
There was a problem hiding this comment.
Let's see how much slowdown this causes.
Contributor
Author
There was a problem hiding this comment.
Ugh, we can't even run these for annoying reasons (namely: an npm dependency). I don't think there's a clean workaround unless the idea in scala-js/scala-js-js-envs#20 (comment) lands which would allow us to drop the npm dep.
Contributor
Author
There was a problem hiding this comment.
Suggested change
| sbtTestCommand = "ciJVM; ciJS", | |
| sbtTestCommand = "ciJVM", |
armanbilge
commented
Jul 28, 2022
| lazy val http4s = SbtCommunityProject( | ||
| project = "http4s", | ||
| sbtTestCommand = """set ThisBuild / tlFatalWarnings := false; server/test; client/test; ember-core/test; ember-server/test; ember-client/test; circe/test""", | ||
| sbtTestCommand = """set ThisBuild / tlFatalWarnings := false; rootJVM/test""", |
Contributor
Author
There was a problem hiding this comment.
We slimmed down the http4s repo (it was previously a monorepo). So we should no longer need to pick-and-choose specific modules.
ckipp01
approved these changes
Jul 28, 2022
Member
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
Thanks for the simplification @armanbilge! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.