Try just disallowing widening of abstract types #16206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
changed the title
dwijnand
force-pushed
the
match-types-completeness
branch
from
0bc377d to
4c63583
Compare
dwijnand
force-pushed
the
match-types-completeness
branch
from
4c63583 to
f616cae
Compare
|
We can try this to get more info, but it's almost certainly not the correct solution. We need to be able to widen abstract types. It makes no sense to disallow it since it would violate narrowing. |
|
Reviewing this with Guillaume this is in a complicated state where we can't tell what is unsound and therefore whether the test expectation changes here are fixes or regressions. So we leave maybe unsound code compile and make reasonable code like #15926 not compile? 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.