Add extension/conversion to GADT selection healing #16638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GADT member selection "healing" logic only accounted for members that belong to the resulting GADT-approximated type, meaning extension methods weren't considered. I moved that logic to typedSelect, so that the resulting tree from running the extension or conversion attempt can be returned. In adaptToSubType it was adapting the qualifier only. For example, we try to extend/convert `a.$asInstanceOf[MyData].printIt` and get back `MyData.printIt(a.$asInstanceOf[MyData])` which we can return (instead of throwing it away and having typedSelect redo the work.) That also puts the new use of `tryExtensionOrConversion` next to the previous use, for the original qualifier type.
dwijnand
force-pushed
the
gadt-ext-method
branch
from
1e4974a to
f6a16cb
Compare
dwijnand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extension/conversion to GADT selection healing
The GADT member selection "healing" logic only accounted for members
that belong to the resulting GADT-approximated type, meaning extension
methods weren't considered.
I moved that logic to typedSelect, so that the resulting tree from
running the extension or conversion attempt can be returned. In
adaptToSubType it was adapting the qualifier only. For example, we try
to extend/convert
a.$asInstanceOf[MyData].printItand get backMyData.printIt(a.$asInstanceOf[MyData])which we can return(instead of throwing it away and having typedSelect redo the work.)
That also puts the new use of
tryExtensionOrConversionnext to theprevious use, for the original qualifier type.