Add an error message for illegal start of simple pattern - Parsers.scala:1437 #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
reviewed
Nov 14, 2016
| case class IllegalStartOfSimplePattern()(implicit ctx: Context) extends Message(32) { | ||
| val kind = "Syntax" | ||
| val msg = "illegal start of simple pattern" | ||
| val explanation = "" |
There was a problem hiding this comment.
This message doesn't really add anything to justify its existence currently. Some things to consider for the explanation:
- When does this occur?
- What is a simple expression?
- Is there perhaps something that could be added to the message in order to help tooling / the user?
Let's try to put some semantics into this :)
|
@felixmulder PTAL |
felixmulder
suggested changes
Nov 15, 2016
| | case List(_, second, x:_*) => second | ||
| | case _ => 0 | ||
| |}""" | ||
| hl"""|Simple pattern can be divided into several groups: |
| | A special case is the wild-card pattern _ which is treated as if it was a fresh | ||
| | variable on each occurrence. | ||
| | | ||
| |- Typed Patterns: ${"case x:Int => ..."} or ${"case _:Int => ..."}. |
|
@felixmulder PTAL. BTW, I ran the 'partest' task from 'sbt' and here's what I've got: I'm not really sure why the jenkins build failed 😞 |
|
Let's just try rebuilding on the CI first |
|
/rebuild |
|
it failed again :( |
|
Hmm, yes. Your branch's working on my machine - @smarter, could you rerun this on a different behemoth? |
|
@felixmulder Looks like it's working again! PTAL |
felixmulder
approved these changes
Nov 16, 2016
|
LGTM, thanks @maseev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the following issue.