Categorize stdlib-bootstrapped TASTy-MiMa issues #17987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
categorize-tasty-mima-issues
branch
from
8abc7fc to
a7f2e4f
Compare
nicolasstucki
added
the
fasttrack
sjrd
reviewed
Jun 16, 2023
project/TastyMiMaFilters.scala
Outdated
| ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.*.<init>"), | ||
|
|
||
| // Problem The symbol scala.*.<init> has a more restrictive visibility qualifier in current version | ||
| // Only on primitive type final abstract classes |
There was a problem hiding this comment.
If it's only on the primitive types, that's at most 9 things. Consider spelling them out explicitly so that you don't catch other constructors by mistake.
project/TastyMiMaFilters.scala
Outdated
| ProblemMatcher.make(ProblemKind.RestrictedVisibilityChange, "scala.*.<init>"), | ||
|
|
||
| // Problem: constructors have a result type the return unit instead of the class type | ||
| ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.*.<init>"), // scala.math.Numeric.CharIsIntegral.<init>; before: (): scala.math.Numeric.CharIsIntegral; after: (): Unit |
There was a problem hiding this comment.
That's an OK. In the bytecode constructors don't have result types at all. It must be tasty-query at fault here.
project/TastyMiMaFilters.scala
Outdated
| // Problem: Case class with varargs | ||
| ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.StringContext.parts"), | ||
| // Problem: Case class with varargs. | ||
| ProblemMatcher.make(ProblemKind.IncompatibleTypeChange, "scala.StringContext.parts"), // before: scala.<repeated>[Predef.String]; after: scala.collection.immutable.Seq[Predef.String] @scala.annotation.internal.Repeated |
There was a problem hiding this comment.
Looks like a tasty-query issue as well. Should be an OK.
nicolasstucki
force-pushed
the
categorize-tasty-mima-issues
branch
from
a7f2e4f to
51e472b
Compare
sjrd
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.