Do not generate _N members for case classes in stdlib-bootstrapped #18117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
from
2a1ea2d to
600a512
Compare
nicolasstucki
force-pushed
the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
from
600a512 to
6aa10c2
Compare
smarter
approved these changes
Jul 10, 2023
| val paramNames = ctx.owner.owner.info.decls.toList.filter(_.flags.is(ParamAccessor)).map(_.name) | ||
| // case N => this.${paramNames(N)} | ||
| val cases = paramNames.zip(0.until(arity)).map { (name, i) => | ||
| val sel = This(clazz).select(name, _.info.isParameterless) |
There was a problem hiding this comment.
Why not directly select the symbol found above instead?
There was a problem hiding this comment.
I followed the previous implementation too closely. Now I am selecting the symbols directly. I also used zipWithIndex instead of the zip with the range.
nicolasstucki
force-pushed
the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
from
6aa10c2 to
1fac412
Compare
|
@smarter I also updated the MiMaFilters. You should double-check those changes. |
smarter
approved these changes
Jul 10, 2023
project/MiMaFilters.scala
Outdated
| @@ -97,6 +92,9 @@ object MiMaFilters { | |||
| ProblemFilters.exclude[MissingTypesProblem]("scala.jdk.IntAccumulator"), | |||
| ProblemFilters.exclude[MissingTypesProblem]("scala.jdk.LongAccumulator"), | |||
| ProblemFilters.exclude[FinalClassProblem]("scala.collection.ArrayOps$ReverseIterator"), | |||
| ProblemFilters.exclude[FinalClassProblem]("scala.Tuple1"), | |||
| ProblemFilters.exclude[FinalClassProblem]("scala.Tuple2"), | |||
| ProblemFilters.exclude[MissingFieldProblem]("scala.Tuple*._*"), // Tuple1._1, Tuple2._1, Tuple2._2 | |||
There was a problem hiding this comment.
Where does this difference come from?
There was a problem hiding this comment.
Not sure if it is a specialization anymore. I will have to investigate further into this one.
There was a problem hiding this comment.
I recategorized these failures
nicolasstucki
force-pushed
the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
from
1fac412 to
c199e45
Compare
nicolasstucki
force-pushed
the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
from
c199e45 to
df3968b
Compare
smarter
approved these changes
Jul 13, 2023
smarter
deleted the
fix-case-class-product-members-in-stdlib-bootstrapped
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #17928