rewiring-dependencies on settings in the bytecode emitter #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -395,7 +388,7 @@ abstract class BCodeHelpers extends BCodeTypes with BytecodeWriters { | |||
|
|
|||
| trait BCInnerClassGen extends HasContext { | |||
|
|
|||
| def debugLevel = settings.debuginfo.indexOfChoice | |||
| def debugLevel = ctx.base.settings.g.indexOfChoice | |||
There was a problem hiding this comment.
ctx.base should not be necessary, there's an implicit def toBase(ctx: Context): ContextBase in the companion object Context
|
Commits added incorporating feedback. review by @lrytz |
|
LGTM with magarciaEPFL/dotty#1 |
context for ClassBytecodeWriter
magarciaEPFL
added a commit
that referenced
this pull request
Feb 14, 2014
rewiring-dependencies on settings in the bytecode emitter
This was referenced Aug 8, 2022
pikinier20
pushed a commit
that referenced
this pull request
Aug 16, 2022
…part Contributors component
WojciechMazur
added a commit
to WojciechMazur/dotty
that referenced
this pull request
Mar 19, 2025
Backport "Add zip and unzip to the CI" to LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review by @lrytz