Backport "feat: hook up actions in sbt-bridge to start forwarding actionable diagnostics" to LTS #19060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Cherry-picked cde8150]
[Cherry-picked 1424f9b]
[Cherry-picked 3a6c368]
[Cherry-picked 4f5ae4c]
[Cherry-picked f55b01c]
[Cherry-picked 89e8f13]
[Cherry-picked 59cb71b]
[Cherry-picked ff8e768]
[Cherry-picked 794216a]
[Cherry-picked e153597]
Instead of keeping track of the delta, we simply reverse the patches and apply them. This shouldn't be problematic because we do a check beforehand ensuring that there aren't overlapping patches. This greatly simplifies the way these are applied for the tests while keeping the same behavior. [Cherry-picked 1cd8007]
This also has a small change where instead of applying all the actions if we are doing a rewrite, we only actually take the first one [Cherry-picked e97fea5]
|
No regressions detected in the community build up to lts-16941. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #17561 to the LTS branch.
PR submitted by the release tooling.
[skip ci]