Revert broken changes with transparent inline #19922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Mar 11, 2024
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 9, 2024
Reverts parts of scala#19922. Fixes scala#20342 The logic that we should ignore declared result types of inline methods really only applies to transparent inlines.
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
May 9, 2024
Reverts parts of scala#19922. Fixes scala#20342, scala#20297 The logic that we should ignore declared result types of inline methods really only applies to transparent inlines.
noti0na1
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
May 14, 2024
Reverts parts of scala#19922. Fixes scala#20342, scala#20297 The logic that we should ignore declared result types of inline methods really only applies to transparent inlines.
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 11, 2024
Reverts parts of scala#19922. Fixes scala#20342, scala#20297 The logic that we should ignore declared result types of inline methods really only applies to transparent inlines.
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 11, 2024
Reverts parts of scala#19922. Fixes scala#20342, scala#20297 The logic that we should ignore declared result types of inline methods really only applies to transparent inlines.
odersky
added a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed in #19415 (comment)
Fixes #19415
Fixes #19479
Reverts #18130 and #17924.
#18130 is still closed as it was introduced by #17924.
This reopens #9685