simplify trees that appear in tastycheck test #21274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
approved these changes
Jul 25, 2024
WojciechMazur
added a commit
that referenced
this pull request
Dec 3, 2024
Backports #21274 to the 3.3.5. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately it seems changing the classpath means representation of TASTy is not stable (but is semantically equivalent) i.e. some SHAREDtype might be replaced by equivalent types. This breaks the tastycheck test in #21214 with scala 2 library tasty.
By changing to ordinary classes instead of enum cases, we limit generated code and avoid these specific examples of instability in the test.
Manually, I confirmed that reverting the change to namer in #21214 still breaks the new test
[test_scala2_library_tasty]