Skip to content

Backport "Fix isomorphism tests of AndOrTypes under non-empty BinderPairs" to 3.5.2 #21468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #21017 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]

som-snytt and others added 2 commits August 28, 2024 10:43
…21017)

Before the changes, when comparing two `HKTypeLambda` result types, the
list of binding pairs was lost when entering comparison of `AndOrType`s,
which caused the `equals` to fail, and hence prevented hash-consing.

Even though `M1` and `M2` in pos/i20858-min should still conform to
one-another, we entered a deep-subtype comparison because of the order
in which the TypeComparer does dealiasing of AppliedTypes, and
comparison of MatchCases and AndTypes.

Fix #20858
[Cherry-picked f2829c3]
@WojciechMazur WojciechMazur merged commit dbfe1e8 into 3.5.x Aug 28, 2024
27 checks passed
@WojciechMazur WojciechMazur deleted the release-3.5.x-21017 branch August 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants