Skip to content

Use symbolic names internally #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarter merged 8 commits into from
May 7, 2017
Merged

Use symbolic names internally #2169

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
693e716
Drop $$local whan mangling fields
odersky May 5, 2017
a6efb02
Make idempotency tests run last
odersky May 5, 2017
c6dafba
Adress reviewers comments
odersky May 6, 2017
dec083a
Make all name kinds strict
odersky May 7, 2017
76e31aa
Fix bug in avoid
odersky May 7, 2017
b10eece
Fix checking condition
odersky May 7, 2017
6e3f325
Add test case
odersky May 7, 2017
d3501e1
Fix NameKinds
odersky May 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions compiler/src/dotty/tools/dotc/core/NameKinds.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ object NameKinds {
def infoString: String
}

/** The kind of SimpleNames */
val SimpleNameKind = new NameKind(UTF8) { self =>
object SimpleNameKind extends NameKind(UTF8) { self =>
Copy link
Copy Markdown
Member

@smarter smarter May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ultimately, we should just make the name registration thread-safe, it doesn't cost much and it's much easier to reason about than remembering which NameKinds have side-effects, etc.

Copy link
Copy Markdown
Contributor Author

@odersky odersky May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is another issue. The problem was not threading but the fact that the registration was not performed at all, since objects are lazy.

Copy link
Copy Markdown
Member

@smarter smarter May 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, indeed that's different. If we had enums we could iterate over the namekinds to register them maybe :).

type ThisInfo = Info
val info = new Info
def mkString(underlying: TermName, info: ThisInfo) = unsupported("mkString")
Expand Down Expand Up @@ -359,7 +358,7 @@ object NameKinds {
val ModuleClassName = new SuffixNameKind(OBJECTCLASS, "$", optInfoString = "ModuleClass")

/** A name together with a signature. Used in Tasty trees. */
val SignedName = new NameKind(63) {
object SignedName extends NameKind(63) {

case class SignedInfo(sig: Signature) extends Info {
override def toString = s"$infoString $sig"
Expand Down