Skip to content

[build] Ensure that scala3-library artifacts are empty #24816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WojciechMazur merged 6 commits into from
Dec 22, 2025
Merged

[build] Ensure that scala3-library artifacts are empty #24816

WojciechMazur merged 6 commits into from
Dec 22, 2025

Conversation

@WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Dec 22, 2025

  • Added task to validate that produced .jar, -sources.jar, -javadoc.jar are effectively empty (contain only META-INF, no .class, .tasty, .sjsir .html, etc)
  • Don't delegate scala3-library-bootstrapepd and scala3-library-sjs for doc tasks to scala-library-bootstrapped tasks - Fixes scala3-library javadoc contains duplicated scala-library documentation #24807
  • Also don't delegate scala3-library-nonboostrapped
  • Deduplicate settings used in all of the mentioned tasks

Piggy backed changes (small improvements unrelated directlly to the core of the PR):

  • simplifiy fetchedScalaInstanceSettings - always use scalaVersion.value
  • ensure that downloaded sbt-scala3-bridge uses the same version as used scalaVersion

@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Dec 22, 2025
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Dec 22, 2025
Gedochao
Gedochao approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechMazur WojciechMazur merged commit 4120987 into scala:main Dec 22, 2025
54 checks passed
@WojciechMazur WojciechMazur deleted the build/scala3-library-empty-javadocs branch December 22, 2025 14:49
@WojciechMazur WojciechMazur mentioned this pull request Dec 22, 2025
Closed
@WojciechMazur WojciechMazur mentioned this pull request Dec 30, 2025
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Dec 30, 2025
WojciechMazur added a commit that referenced this pull request Dec 31, 2025
@WojciechMazur
Backport "[build] Ensure that scala3-library artifacts are empty" t…
dc051b8 
…o 3.8.0 (#24861)

Backports #24816 to the 3.8.0-RC5.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gedochao Gedochao Gedochao approved these changes

@tgodzik tgodzik Awaiting requested review from tgodzik

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

scala3-library javadoc contains duplicated scala-library documentation

2 participants

@WojciechMazur @Gedochao