Skip to content

[build] Use up-to-date sources of Scala 2.13 stdlib when patching Scala 3 bytecode #24855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WojciechMazur merged 3 commits into from
Dec 30, 2025
Merged

[build] Use up-to-date sources of Scala 2.13 stdlib when patching Scala 3 bytecode #24855

WojciechMazur merged 3 commits into from
Dec 30, 2025

Conversation

@WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Dec 30, 2025

  • Update the version of mtags_shared and Scala 2 stdlib to use 2.13.18 artifact instead of 2.13.16
  • Removed no longer used Build.stdlibBootstrappedVersion

tgodzik
tgodzik reviewed Dec 30, 2025
View reviewed changes
project/MiMaFilters.scala
Build.mimaPreviousDottyVersion -> Seq.empty, // We should never break backwards compatibility
Build.mimaPreviousDottyVersion -> Seq(
// scala/scala3#24855 - copied from Scala 2.13.16 by ScalaLibraryPlugin, to be removed when Scala 3.8.0 is released
ProblemFilters.exclude[MissingClassProblem]("scala.collection.immutable.LazyList$State*"),
Copy link
Contributor

@tgodzik tgodzik Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe? Are we not breaking the binary compatibility here?

Copy link
Contributor Author

@WojciechMazur WojciechMazur Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same in Scala 2, it was also adds in their MiMa scala/scala#10937 it was removed when they've started to work on 2.13.18 scala/scala@2f929e8 (Scala 2 checks MiMa only against previous version)

We're de facto synchronized with Scala 2.13.18, LazyList.State is a private sealed trait

tgodzik
tgodzik approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WojciechMazur WojciechMazur merged commit 6f74f91 into scala:main Dec 30, 2025
56 checks passed
@WojciechMazur WojciechMazur deleted the stdlib/2.13.18 branch December 30, 2025 11:44
@WojciechMazur WojciechMazur added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Dec 30, 2025
@WojciechMazur WojciechMazur added this to the 3.8.0 milestone Dec 30, 2025
@WojciechMazur WojciechMazur mentioned this pull request Dec 30, 2025
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Dec 30, 2025
WojciechMazur added a commit that referenced this pull request Dec 31, 2025
@WojciechMazur
Backport "[build] Use up-to-date sources of Scala 2.13 stdlib when pa…
bee78a7 
…tching Scala 3 bytecode" to 3.8.0 (#24868)

Backports #24855 to the 3.8.0-RC5.

PR submitted by the release tooling.
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Dec 31, 2025
@SethTisue SethTisue mentioned this pull request Jan 12, 2026
Open
@WojciechMazur WojciechMazur mentioned this pull request Jan 13, 2026
Merged
WojciechMazur added a commit that referenced this pull request Jan 13, 2026
@WojciechMazur
Backport "[build] Use up-to-date sources of Scala 2.13 stdlib when pa…
84f9b39 
…tching Scala 3 bytecode" to 3.8.1 (#24952)

Backports #24855 to the 3.8.1-RC1.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@WojciechMazur @tgodzik