Encapsulate SemanticDB package, unify symbol and document printing #25084
Conversation
…tDocumentProvider
| |object O/*_empty_.O.*/ { | ||
| | val a/*_empty_.O.a.*/ = 123 | ||
| | val b/*_empty_.O.b.*/ = a/*_empty_.O.a.*/ +/*scala.Int#`+`(+4).*/ 1 | ||
| |object O/*<-_empty_::O.*/ { |
There was a problem hiding this comment.
did you change the way the extractor works or something? - oh most likely reusing the existing printer rather than whatever they were using
There was a problem hiding this comment.
No, the presentation-compiler's test code to print a text document was slightly different than the compiler's test code, this moves to the compiler's version
| val idx = rest.indexWhere(filter).ensuring(_ >= 0) | ||
| b.append('+').append(idx + 1) | ||
| val idx = rest.indexWhere(filter) | ||
| if idx >= 0 then b.append('+').append(idx + 1) |
There was a problem hiding this comment.
This here is the one change in the existing (compiler) version to accommodate the presentation-compiler: there are cases where we don't find a symbol matching filter in alts at all, so using ensuring would crash. The presentation-compiler's version already had this if.
| end localIdx | ||
|
|
||
| private[semanticdb] object SemanticSymbolBuilder: | ||
| def inverseSymbol(sym: String)(using ctx: Context): List[Symbol] = |
There was a problem hiding this comment.
Moved as-is from the presentation-compiler, so that only the compiler has to reach into the internals of the semanticdb package.
3 participants
Possibly controversial.
Review commit by commit, I rewrote history to make that easier.