Fixes for global capabilities #25123
Open
+611
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stateful will probably be not well known, so it's helpful to also mention the possibility to extend Mutable.
We need to know whether any external references are real capabilities with nonempty capture sets.
When deciding which IncludeFailure to print, prefer capabilities that are not static owners. Static owners are often capabilities only indirectly and they can be synthetic package objects, which makes error messages less understandable.
Just in case; does not seem to make a difference for the checkfiles yet.
Previously, if a first include succeeded and a following tryInclude failed, the elements added by the first tryInclude would have been left in the set even though the whole operation failed.
Contributor
We previously forgot the case where a static reference is a simple ident `id`. This needs to be treated like `this.id`, where `this` referes to the enclosing object. We get a new error for minicheck.scala which goes away when things are put into an explicit object. This needs follow-up.
odersky
force-pushed
the
fix-mutability2
branch
from
b63cc21 to
e5ae14a
Compare
The capture set of infos can be recursive, for instance if global objects have mutual dependencies.
If a uses or uses_init clause is absent, assume it's the empty set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes and improvements around global capabilities
the elements added by the first tryInclude would have been left in the set
even though the whole operation failed.
id. This needs to be treated likethis.id, wherethisreferes to the enclosing object.We get a new error for minicheck.scala doe to the last change which goes away when things are put into
an explicit object. This needs follow-up.