Fix behavior of -Ydump-sbt-inc
#25125
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdziuban
changed the title
sendToZinc after dumping sbt incremental compilation info.-Ydump-sbt-inc
This fixes an issue introduced in scala#24969 where the output generated by `-Ydump-sbt-inc` never includes any used names or dependencies. The problem occurs because [`sendToZinc` calls `clear()`](https://github.com/scala/scala3/blob/388248140f264d52d9199c5a266e220b2be4433c/compiler/src/dotty/tools/dotc/sbt/ExtractDependencies.scala#L458), which calls [`_foundDeps.clear()`](https://github.com/scala/scala3/blob/388248140f264d52d9199c5a266e220b2be4433c/compiler/src/dotty/tools/dotc/sbt/ExtractDependencies.scala#L462). As a result, `rec.foundDeps` is always empty when generating the info to dump. This fixes it by moving the call to `sendToZinc` to occur after dumping data using `rec.foundDeps`. This aligns with how `-Ydump-sbt-inc` worked [when it was handled in `ExtractDependencies.scala`](https://github.com/scala/scala3/pull/24969/changes#diff-5a8383a96e18900140707151f3f9f47cb9d89c3d64498f4bc70f554f9c780bccL81-L100) prior to being moved to `Inlining.scala`.
mrdziuban
force-pushed
the
fix-Ydump-sbt-inc
branch
from
8d1a40d to
d51b631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #24969 where the output generated by
-Ydump-sbt-incnever includes any used names or dependencies.The problem occurs because
sendToZinccallsclear(), which calls_foundDeps.clear(). As a result,rec.foundDepsis always empty when generating the info to dump.This fixes it by moving the call to
sendToZincto occur after dumping data usingrec.foundDeps. This aligns with how-Ydump-sbt-incworked when it was handled inExtractDependencies.scalaprior to being moved toInlining.scala.