Preserve type info when lifting stable arguments - #26063
Merged
Merged
Conversation
SolalPirelli
approved these changes
May 16, 2026
SolalPirelli
left a comment
SolalPirelli
left a comment
Contributor
There was a problem hiding this comment.
less widening is good, I guess? I'm not super familiar with this, but it's a small change and passes tests
bishabosha
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 5, 2026
Fixes scala#25557 The type of lifted arguments was always widened, which affects the behavior of `avoid` and breaks dependent path types in the `foo(parent, isFoo)`'s result type. ```scala { val parent$1: ConcreteParent = ConcreteParent ConcreteParent.foo(parent = parent$1, isFoo = true)((_$2: ConcreteParent) => _$2.myInner) } ``` ## How much have you relied on LLM-based tools in this contribution? Extensively, for finding which code trigger the bug and how to fix it. ## How was the solution tested? Used reproducer provided from the issue.
This was referenced Jul 14, 2026
Gedochao
pushed a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25557
The type of lifted arguments was always widened, which affects the behavior of
avoidand breaks dependent path types in thefoo(parent, isFoo)'s result type.{ val parent$1: ConcreteParent = ConcreteParent ConcreteParent.foo(parent = parent$1, isFoo = true)((_$2: ConcreteParent) => _$2.myInner) }How much have you relied on LLM-based tools in this contribution?
Extensively, for finding which code trigger the bug and how to fix it.
How was the solution tested?
Used reproducer provided from the issue.