Emit a super init call for primitives on the JVM - #26630
Open
SolalPirelli wants to merge 1 commit into
Open
Conversation
SolalPirelli
commented
Jul 27, 2026
| val pool = JExecutors.newWorkStealingPool(threadLimit.getOrElse(Runtime.getRuntime.availableProcessors())) | ||
| val timer = new Timer() | ||
| val logProgress = isInteractive && !suppressAllOutput | ||
| val logProgress = sourceCount > 1 && isInteractive && !suppressAllOutput |
Contributor
Author
There was a problem hiding this comment.
There's no point in a progress bar when running a single test and it's annoying for prints.
SolalPirelli
marked this pull request as ready for review
July 27, 2026 09:50
SolalPirelli
added
the
backport:nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26576
Since this is a JVM-specific requirement, I did it in the JVM backend. We could also change
Mixin.transformTemplateto remove the special-casing of primitive value classes, but this would require other changes, and it seems wrong to, e.g., tell Scala.js to include a call to scala.AnyVal or j.l.Object's init in scala.Int's init.Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)