Skip to content

Scaladoc: add fallback lookup from nearest package - #26661

Open
SolalPirelli wants to merge 2 commits into
scala:mainfrom
dotty-staging:solal/potato
Open

Scaladoc: add fallback lookup from nearest package#26661
SolalPirelli wants to merge 2 commits into
scala:mainfrom
dotty-staging:solal/potato

Conversation

@SolalPirelli

Copy link
Copy Markdown
Contributor

Fixes #26627

Have you relied on LLM-based tools in this contribution?

No. Not super confident in this though.

How was the solution tested?

Manual tests because writing automated tests is impractical, described below (in detail)

I ran scaladoc on the tasty from compiling the thing in the repro. I don't know how to make an automated test for scaladoc here.

@SolalPirelli
SolalPirelli requested a review from Gedochao July 30, 2026 12:07
@SolalPirelli
SolalPirelli marked this pull request as ready for review July 30, 2026 12:07
def ClassDefWithParents(cls: ClassSymbol, constr: DefDef, parents: List[Tree], body: List[Tree])(using Context): TypeDef = {
val selfType =
if (cls.classInfo.selfInfo ne NoType) ValDef(newSelfSym(cls))
if (cls.info ne NoType) && (cls.classInfo.selfInfo ne NoType) then ValDef(newSelfSym(cls))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was another cause of crash, .classInfo is an .asInstanceOf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaladoc regression for references to scala.concurrent

2 participants