Scaladoc: add fallback lookup from nearest package - #26661
Open
SolalPirelli wants to merge 2 commits into
Open
Conversation
SolalPirelli
commented
Jul 30, 2026
| def ClassDefWithParents(cls: ClassSymbol, constr: DefDef, parents: List[Tree], body: List[Tree])(using Context): TypeDef = { | ||
| val selfType = | ||
| if (cls.classInfo.selfInfo ne NoType) ValDef(newSelfSym(cls)) | ||
| if (cls.info ne NoType) && (cls.classInfo.selfInfo ne NoType) then ValDef(newSelfSym(cls)) |
Contributor
Author
There was a problem hiding this comment.
this was another cause of crash, .classInfo is an .asInstanceOf
SolalPirelli
force-pushed
the
solal/potato
branch
from
July 30, 2026 13:41
afdeaa2 to
a48bd3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26627
Have you relied on LLM-based tools in this contribution?
No. Not super confident in this though.
How was the solution tested?
Manual tests because writing automated tests is impractical, described below (in detail)
I ran scaladoc on the tasty from compiling the thing in the repro. I don't know how to make an automated test for scaladoc here.