Fix capture checker crash when mapping a Var capture set - #26667
Open
Linyxus wants to merge 1 commit into
Open
Conversation
…Local
A dependent capture set such as `{any, f}` becomes a `Union` variable
containing `any` when `f` is instantiated with an argument whose capture
set is still a variable. When such a var is later mapped by a BiTypeMap
under `withNoVarsMapped` (e.g. `GlobalCapToLocal` in
`CheckCaptures.recheckArg`), the map changes existing elements, which
tripped the assertion in `CaptureSet.map` that required the map to be
element-identity in this mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dependent capture set such as
{any, f}becomes aUnionvariable containinganywhenfis instantiated with an argument whose capture set is still a variable. When such a var is later mapped by a BiTypeMap underwithNoVarsMapped(e.g.GlobalCapToLocalinCheckCaptures.recheckArg), the map changes existing elements, which tripped the assertion inCaptureSet.mapthat required the map to be element-identity in this mode.Fixes #26649.
Have you relied on LLM-based tools in this contribution?
Yes, the crash was investigated and fixed by Kimi K3. I checked the changes with my brain. It looks reasonable to me, but I am no way an expert in capture inference.
How was the solution tested?
New automated tests