Fix "Find all references" in the IDE with external projects #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Find all references" worked on dotty itself because all its dotty-compiled dependencies are internal, but in other projects it failed when trying to construct a SourceTree for trees in the dotty library, because sym.sourceFile returned null, because the SourceFile annotation pointed to a path that does not exist on the user filesystem. For now, we just discard these trees, but we need to find some way to match them with source jars.
felixmulder
approved these changes
Jun 26, 2017
Contributor
felixmulder
left a comment
felixmulder
left a comment
There was a problem hiding this comment.
LGTM if there's an issue to track "Find all references" in external projects
Member
Author
|
About to catch flight, will open issue later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Find all references" worked on dotty itself because all its
dotty-compiled dependencies are internal, but in other projects it
failed when trying to construct a SourceTree for trees in the dotty
library, because sym.sourceFile returned null, because the SourceFile
annotation pointed to a path that does not exist on the user filesystem.
For now, we just discard these trees, but we need to find some way to
match them with source jars.