Fix #2636: Move last phase period assertion #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkDimius
reviewed
Aug 3, 2017
| ) | ||
|
|
||
| private def checkedIdOverflow(phase: Phase): Phase = { |
DarkDimius
suggested changes
Aug 3, 2017
| ) | ||
|
|
||
| private def checkedIdOverflow(phase: Phase): Phase = { | ||
| assert(phase.id <= Periods.MaxPossiblePhaseId) |
There was a problem hiding this comment.
would this ever fail? Phase.id extracts it from the period inside the phase, i.e. it reads a field which you're supposedly testing for overflow.
There was a problem hiding this comment.
I propose to do the test in Phase.init instead.
There was a problem hiding this comment.
I don't know if it will ever fail, but that was the check that was there before. Probably at some point this was failing.
|
@DarkDimius merged contents of both PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.