Fix #3213: Make PolyTypes generative #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because PolyTypes are used as carriers of constrained parameter references, we must make sure that we can duplicate them so that the duplicate is different from the original. Hence, it's useless to cache PolyTypes.
|
I don't think you need to always make them generative, just when calling |
The problem is that the constraints map will then re-merge polytypes because they are |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3239/ to see the changes. Benchmarks is based on merging with master (432ceac) |
Fixes scala#2981 which was a duplicate of scala#3213
smarter
approved these changes
Oct 4, 2017
odersky
added a commit
to dotty-staging/dotty
that referenced
this pull request
Oct 8, 2017
This is a partial revert from scala#3239. scala#3239 made both HKLambdas and PolyTypes uncached. It turns out that this breaks things if we do it for HKLambdas. I have not yet figured out why, however. The test case in scala#3250 is a bit too large to be able to tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PolyTypes are used as carriers of constrained parameter references,
we must make sure that we can duplicate them so that the duplicate is
different from the original. Hence, it's useless to cache PolyTypes.