Fix #3252: Generalize constraint handling when harmonizing #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When harmonizing repeated arguments we needed to backtrack the constraint. It turns out we need to do the same thing in all other situations where harmonization takes place.
odersky
changed the title
|
Fixes #3252 |
|
Actually scalac can harmonize even further: def totalDuration(results: List[Long], cond: Boolean): Long =
results.map { r =>
if (cond) r
else if (cond) 0
else (1: Short)
}.sumDotty doesn't handle nested control structures |
|
In scalac: scala> def foo(cond: Boolean) = if (cond) (0: Short) else if (cond) 1 else 2L
foo: (cond: Boolean)LongIn Dotty with this patch: scala> def foo(cond: Boolean) = if (cond) (0: Short) else if (cond) 1 else 2L
def foo(cond: Boolean): AnyVal |
|
Yes, the differences with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When harmonizing repeated arguments we needed to backtrack the
constraint. It turns out we need to do the same thing in all other
situations where harmonization takes place.