Add color to tasty printer #3529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Nov 22, 2017
| @@ -22,8 +23,8 @@ class TastyPrinter(bytes: Array[Byte])(implicit ctx: Context) { | |||
|
|
|||
| def printNames() = | |||
| for ((name, idx) <- nameAtRef.contents.zipWithIndex) { | |||
| val index = "%4d: ".format(idx) | |||
| println(index + nameToString(name)) | |||
| val index = Magenta("%4d".format(idx)) | |||
There was a problem hiding this comment.
I would add a layer of abstraction, e.g. "NameColor" instead of "Magenta"
nicolasstucki
force-pushed
the
colored-tasty
branch
from
fbee942 to
d99cd03
Compare
Makes clear the distinction between name indices, tree indices and tree lengths.
nicolasstucki
force-pushed
the
colored-tasty
branch
from
d99cd03 to
a3f4f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes clear the distinction between name indices, tree indices and tree lengths.