Skip to content

Fix #3633: Inline trees can be pure #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Fix #3633: Inline trees can be pure #3659

merged 1 commit into from
Dec 12, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 12, 2017

Need to be handled like blocks for determining their purity.

@odersky odersky requested a review from allanrenucci December 12, 2017 07:53
@odersky odersky changed the title Inline trees can be pure Fix #3633: Inline trees can be pure Dec 12, 2017
allanrenucci
allanrenucci approved these changes Dec 12, 2017
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also add the test case

@odersky @allanrenucci
Fix scala#3633: Inline trees can be pure
9a86612 
Need to be handled like blocks for determining their purity.
@allanrenucci
Copy link
Contributor

I've added the test case. Merging when the CI is green

@allanrenucci allanrenucci merged commit 9de3905 into scala:master Dec 12, 2017
@allanrenucci allanrenucci deleted the fix-#3633 branch December 12, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrenucci allanrenucci allanrenucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @allanrenucci