-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #3664: Run test
in CI instead of testAll
#3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11b3b36
to
32b02dc
Compare
testAll
part of commonSettings
testAll
part of commonSettings
smarter
reviewed
Dec 13, 2017
project/Build.scala
Outdated
@@ -121,10 +121,17 @@ object Build { | |||
// Change this to true if you want to bootstrap using a published non-bootstrapped compiler | |||
bootstrapFromPublishedJars := false, | |||
|
|||
// enable improved incremental compilation algorithm | |||
incOptions := incOptions.value.withNameHashing(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been on by default for years.
c596edb
to
7dc02c0
Compare
testAll
part of commonSettings
test
in CI instead of testAll
9ef1b8d
to
545a42e
Compare
nicolasstucki
suggested changes
Dec 14, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SlowTests
should only execute on the CI or under testOnly
.
We remove `testAll` which is now equivalent to `test`. If one only want to run the compilation tests, he can use the `vulpix` command. This commit also, clean the sbt build
545a42e
to
1f25a04
Compare
nicolasstucki
approved these changes
Dec 18, 2017
allanrenucci
added a commit
to dotty-staging/dotty
that referenced
this pull request
Dec 18, 2017
allanrenucci
added a commit
that referenced
this pull request
Jan 4, 2018
Update documentation after #3665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove
testAll
which is now equivalent totest
. If one only want to run the compilation tests, he can use thevulpix
command.This commit also, clean the sbt build