Fix #1905: Detect case where bridge would clash with the member #3710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With value classes it is possible that a bridge is needed because the semi erased types of a member and its overridden method differ, yet the fully erased types of the member and the bridge are the same. With this commit we flag this situation as an error. Before it generated a ClassCastException at runtime instead.
Print a reference to a parameter with just the name (e.g. "A") instead of "C.this.A".
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/3710/ to see the changes. Benchmarks is based on merging with master (1080529) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With value classes it is possible that a bridge is needed because the semi erased
types of a member and its overridden method differ, yet the fully erased types
of the member and the bridge are the same. With this commit we flag this situation
as an error. Before it generated a ClassCastException at runtime instead.