Fix #3624: Lazily evaluate static module accessors #3719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not use lazy evaluation for static objects, because these are usually evauated lazily by the backend. But that does not hold if the static module is an (accessor) def instead of a val.
smarter
reviewed
Dec 31, 2017
| if (!(sym is Flags.Lazy) || | ||
| sym.owner.is(Flags.Trait) || | ||
| (sym.isStatic && sym.is(Flags.Module, butNot = Flags.Method))) | ||
| tree |
There was a problem hiding this comment.
Maybe add a comment here explaining why this is OK in these cases?
smarter
reviewed
Dec 31, 2017
tests/run/i3634.scala
Outdated
|
|
||
| object Test { | ||
| def main(args: Array[String]): Unit = { | ||
| assert(Bar.Foo == Bar.Foo) // false |
There was a problem hiding this comment.
I would use eq instead of == to be extra sure that nothing funny is going on.
There was a problem hiding this comment.
Also add a object Baz extends T and assert(Bar.Foo ne Baz.Foo)
odersky
changed the title
smarter
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not use lazy evaluation for static objects, because these are usually evauated
lazily by the backend. But that does not hold if the static module is an (accessor) def
instead of a val.