Skip to content

Added error message for Symbol is not a value #1589 #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

benkobalog
Copy link
Contributor

  1. Added SymbolIsNotAValue error Message class
  2. Substituted the original error message at Checking.scala:526 with the new class and added a test
  3. Typo fix at Checking.scala:211

In place of this pr.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Added" instead of "Add")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@allanrenucci allanrenucci force-pushed the ErrorMessage-SymbolIsNotAValue branch from 34e0e3e to 0a4dca6 Compare January 29, 2018 15:38
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benkobalog for the contribution. I removed the explain section. I thought it didn't add much value for this simple error.

I also made an unrelated change to another error message.

@allanrenucci allanrenucci merged commit 0cf569f into scala:master Jan 29, 2018
@benkobalog benkobalog deleted the ErrorMessage-SymbolIsNotAValue branch January 29, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants