Skip to content

Remove references to the magic package <special-ops> from TASTY #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Apr 24, 2018

No description provided.

smarter added 2 commits April 24, 2018 17:40
Instead we desugar 'foo to scala.quoted.Expr.apply(foo) and
'T to scala.quoted.Expr.apply[T]. This avoids storing references to
the compiler-specific <special-ops> magic package in TASTY trees.

This also gets rid of typedQuote by doing the desugaring early in
desugar#apply instead.
Previously, we pickled references to the magic method
<special-ops>.throw which is compiler-specific.
@smarter smarter self-assigned this Apr 24, 2018
@smarter smarter requested a review from odersky April 24, 2018 16:15
@smarter smarter assigned odersky and unassigned smarter Apr 24, 2018
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@odersky odersky removed their assignment Apr 27, 2018
@odersky odersky merged commit 1e9430a into scala:master Apr 27, 2018
@allanrenucci allanrenucci deleted the tasty/no-specialops branch April 27, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants