Refactor "method does not take parameter" error message #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
reviewed
Jun 4, 2018
| val explanation = | ||
| s"""|You have specified more parameter lists as defined in the method definition(s). | ||
| |$noParameters""".stripMargin | ||
| "You have specified more parameter lists as defined in the method definition(s)." + addendum |
There was a problem hiding this comment.
@allanrenucci s/as defined/than defined/, no?
There was a problem hiding this comment.
Probably. I reuse the same wording as in the initial error message. Feel free to open a new PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change I initially made as part of #4132. I decided to create a separate PR.
I changed the tests not to rely on pretty printing of singleton types and ended up refactoring the error message.