Refactorings on Names: forbid .name on Name and cleanups on the way
#4834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current type is inconsistent with other uses of likeSpaced. And mentioning `name` in a return type would prevent making it private as in next commit.
This is easy for `TermNameDecorator`, and last commit makes it easy for `NameDecorator`.
This lets you think that `tree.name` is sensible tho it isn't, and for more than an year (since ce333b1).
allanrenucci
approved these changes
Jul 24, 2018
| @@ -98,7 +98,7 @@ object Names { | |||
| /** A name in the same (term or type) namespace as this name and | |||
| * with same characters as given `name`. | |||
| */ | |||
| def likeSpaced(name: Name): ThisName | |||
| def likeSpaced(name: PreName): ThisName | |||
There was a problem hiding this comment.
Currently, there don't seems to be usages for likeSpaced(PreName) so I would keep the API as is. If you want to share the implementation with the one in NameOps, it seems you can actually replace PreName by Name
Do you mind if I do a GitHub squash merge instead (once tests pass)? These are intentionally separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you know you could call
.nameon aName? No more! 😄Extracted from #4729 after we saw more with @allanrenucci , assigned to him.