Add additional test case for #4661 #4950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case comes from scala#4660, which is a related bug.
Blaisorblade
approved these changes
Aug 15, 2018
There was a problem hiding this comment.
LGTM. But this doesn't quite fix #4660 since that issue asks for an actual explanation for the warnings, which is a much bigger task. Luckily, the PR as written won't auto-close that issue, so it's OK.
liufengyun
approved these changes
Aug 15, 2018
| @@ -0,0 +1,15 @@ | |||
| class C { | |||
There was a problem hiding this comment.
The convention is to prefix the test file name by i. The tests starting with t are the ones that come from scalac IIRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case comes from #4660, which is a related bug.