TASTy reflect use complete definition trees #4968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
from
71202fc to
1b0297e
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
2 times, most recently
from
3736296 to
1e40bd1
Compare
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
from
1e40bd1 to
0fde9fa
Compare
|
Rebased |
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
2 times, most recently
from
f8c5b25 to
41bc57a
Compare
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
2 times, most recently
from
9aacd4c to
6446173
Compare
Currently only works with -Yretain-tree. Also fix an issue with TASTy reflect
nicolasstucki
force-pushed
the
load-tree-for-symbol
branch
from
6446173 to
0289c31
Compare
|
Rebased |
|
@odersky, now this PR used the |
nicolasstucki
requested review from
liufengyun
and removed request for
odersky
nicolasstucki
changed the title
liufengyun
reviewed
Oct 2, 2018
| @@ -286,7 +286,7 @@ trait TreeOps extends TastyCore { | |||
|
|
|||
| val Inlined: InlinedExtractor | |||
| abstract class InlinedExtractor { | |||
| def unapply(tree: Tree)(implicit ctx: Context): Option[(Option[Term], List[Definition], Term)] | |||
| def unapply(tree: Tree)(implicit ctx: Context): Option[(Option[Parent], List[Definition], Term)] | |||
There was a problem hiding this comment.
If I understand correctly, Parent is the type of the tree in the parent list. Using here, it's a little difficult to understand.
There was a problem hiding this comment.
Yes, I will change Parent to TermOrTypeTree in another PR. When bootstrapped it will be Term | TypeTree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASTy reflect trees are loaded by finding the tree from the current top-level class tree. This only works when
-Yretain-treesis enabled, otherwise the three is still synthesized.