enclosingInlineds: Clarify invariants #5009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
force-pushed
the
clarify-enclosedInvariants-dropInlined
branch
from
7305713 to
cfd21a8
Compare
This comment has been minimized.
This comment has been minimized.
Blaisorblade
force-pushed
the
clarify-enclosedInvariants-dropInlined
branch
from
cfd21a8 to
ed3137f
Compare
|
Moved the failing test to #5048; this PR is now cleanup-only. |
|
Failure is spurious (#5021). |
|
@nicolasstucki I think you picked everything useful from here? Can I close? Assigning to you for the moment (feel free to reassign back). |
nicolasstucki
suggested changes
Dec 10, 2018
| @@ -385,8 +385,8 @@ class RefinedPrinter(_ctx: Context) extends PlainPrinter(_ctx) { | |||
| case SeqLiteral(elems, elemtpt) => | |||
| "[" ~ toTextGlobal(elems, ",") ~ " : " ~ toText(elemtpt) ~ "]" | |||
| case tree @ Inlined(call, bindings, body) => | |||
| (("/* inlined from " ~ toText(call) ~ " */ ") `provided` | |||
| !call.isEmpty && !homogenizedView && !ctx.settings.YshowNoInline.value) ~ | |||
| ((if (!call.isEmpty) "/* inlined from " ~ toText(call) ~ " */ " else "/* inline arg */ ": Text) `provided` | |||
There was a problem hiding this comment.
This change should be reverted, we already do this with a slightly different logic.
|
@Blaisorblade Can we get this over the finish line please? |
|
Asked, @nicolasstucki confirms this code is going to be refactored significantly by your current position changes. So closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, followup to #4990 and #4949.
I also tried ensuring parameters are always nested in calls and boy is that false - we forget using inlineContext often enough, which could be a trap if we use implicit conversion
sourcePos.